fix: build dashboard workspace#306
Merged
RafikiTiki merged 2 commits intoFeb 22, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: afa2b58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
grzegorzkruk
force-pushed
the
fix/dashboard-replace-deprecated-node-sass-with-sass
branch
from
35dd0f4 to
1aaa196
Compare
replace deprecated node-sass with sass
jbroma
force-pushed
the
fix/dashboard-replace-deprecated-node-sass-with-sass
branch
from
b347752 to
afa2b58
Compare
jbroma
approved these changes
Feb 22, 2023
RafikiTiki
approved these changes
Feb 22, 2023
RafikiTiki
deleted the
fix/dashboard-replace-deprecated-node-sass-with-sass
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem:
yarn buildin root dir crashes duringdashboard:buildphase on M1 (arm64). The reason is use of deprecatednode-sassdep indashboardworkspace.Solution:
Replace
node-sasswith latestsassTest plan
Execute
yarn buildin root dir on M1 based Mac machine.